feat(site): allow selecting an organization when creating a template #14061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After reading the PR description again, I can see how difficult it can be to test locally. I think our tests can catch most of the bugs we may have so I will move forward and approve the PR but please let me know if you want a QA on dev.coder.com when it gets merged. |
BrunoQuaresma
approved these changes
Jul 31, 2024
|
ok, this is basically ready to merge, but I need to do a little bit of tweaking with links and navigation that I think would probably be better off in a separate PR, rather than making this one even larger. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13877
Closes #13879
This PR is kind of massive because all of the existing template views assume that the template you're looking at is in the default org. Allowing creating a template under any org, means all of this UI needs to be updated, some tests need to change, etc. This even sparked a pretty large backend change (tho that became its own PR and has already been merged).
Important note (reviewers, seriously please read this)
You currently cannot find the template you created in the UI on the /templates page. This is intentional! That work was already completed in a different PR, which unfortunately got reverted. This change is purely to enable creating templates in other orgs, and is already large. The rest of the flow will come (back) later. :)
Make sure you have a provisioner connected to whatever org you want to create a template for if you try kicking the tires on this. This requires some manual effort and know-how, so please let me know if you need help testing.