chore: add sql filter to fetching audit logs #14070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous replayed 100 user sessions and took 759 visual snapshots. Meticulous has not yet run on 956d0cb of the main branch and so there was nothing to compare against. Last updated for commit 2709d4b. This comment will update as new commits are pushed. |
johnstcn
reviewed
Aug 1, 2024
johnstcn
approved these changes
Aug 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
This adds a SQL filter to fetching audit logs. Prior to this change, all audit logs shared the same authorization call, so only 1 was done up front. Now that we have organizational scoped audit logs, listing all audit logs a user can view will operate like workspaces.
The SQL filter is required for pagination, as the filtering has to occur in the database.