feat: allow admins to modify notification template delivery method #14116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @dannykopping and the rest of your teammates on |
|
Meticulous was unable to execute a test run for this PR because the most recent commit is associated with multiple PRs. To execute a test run, please try pushing up a new commit that is only associated with this PR. Last updated for commit 33e9bc9. This comment will update as new commits are pushed. |
a38ce71 to
b7c9ca8
Compare
2105aa4 to
c4b8b31
Compare
4a0e0f2 to
8041cc7
Compare
6ea0336 to
2cc690c
Compare
0386dab to
8bec5b1
Compare
dannykopping
commented
Aug 5, 2024
Comment on lines
+56
to
+58
| dispatchMethod := s.defaultMethod | ||
| if metadata.CustomMethod.Valid { | ||
| dispatchMethod = metadata.CustomMethod.NotificationMethod |
Contributor
Author
There was a problem hiding this comment.
Here is where the new dispatch method is chosen
f2926a3 to
b3679fe
Compare
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
b3679fe to
d627fef
Compare
2cc690c to
c744d33
Compare
johnstcn
reviewed
Aug 5, 2024
johnstcn
reviewed
Aug 5, 2024
johnstcn
approved these changes
Aug 5, 2024
Signed-off-by: Danny Kopping <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of coder/internal#19
Admins must be able to modify which delivery method is set for each notification template. For all templates with a method not set, it falls back to the deployment-wide setting.
This PR enables the above functionality, and modifies the notification dispatch process to take custom dispatch methods per template into account.
Added two new routes:
PUT /notifications/templates/{notification_template}/methodGET /notifications/templates/systemsystemAlso made some small drive-by changes to the notification settings work recently implemented.