-
Notifications
You must be signed in to change notification settings - Fork 881
refactor: Improve the load state for the list pages #1428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4cef295
Improve loading for Users
BrunoQuaresma c0824d5
Refactor templates table
BrunoQuaresma e1e6d9d
Add total label
BrunoQuaresma 40afc47
Improve empty state
BrunoQuaresma c76d68c
Refactor template page to use MUI table
BrunoQuaresma 6b37868
Add templates table
BrunoQuaresma b3bdc36
Add workspaces table
BrunoQuaresma 8524f1f
Add loading states on storybook
BrunoQuaresma 036d18f
Merge branch 'main' of github.com:coder/coder into bq/refactor-full-p…
BrunoQuaresma f52bb68
Fix EmptyState tests
BrunoQuaresma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
import { Story } from "@storybook/react" | ||
import React from "react" | ||
import { MockUser, MockUser2 } from "../../testHelpers/entities" | ||
import { NavbarView, NavbarViewProps } from "./NavbarView" | ||
|
||
export default { | ||
|
@@ -14,33 +15,15 @@ const Template: Story<NavbarViewProps> = (args: NavbarViewProps) => <NavbarView | |
|
||
export const ForAdmin = Template.bind({}) | ||
ForAdmin.args = { | ||
user: { | ||
id: "1", | ||
username: "Administrator", | ||
email: "[email protected]", | ||
created_at: "dawn", | ||
status: "active", | ||
organization_ids: [], | ||
roles: [], | ||
}, | ||
displayAdminDropdown: true, | ||
user: MockUser, | ||
onSignOut: () => { | ||
return Promise.resolve() | ||
}, | ||
} | ||
|
||
export const ForMember = Template.bind({}) | ||
ForMember.args = { | ||
user: { | ||
id: "1", | ||
username: "CathyCoder", | ||
email: "[email protected]", | ||
created_at: "dawn", | ||
status: "active", | ||
organization_ids: [], | ||
roles: [], | ||
}, | ||
displayAdminDropdown: false, | ||
user: MockUser2, | ||
onSignOut: () => { | ||
return Promise.resolve() | ||
}, | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
import Box from "@material-ui/core/Box" | ||
import CircularProgress from "@material-ui/core/CircularProgress" | ||
import { makeStyles } from "@material-ui/core/styles" | ||
import TableCell from "@material-ui/core/TableCell" | ||
import TableRow from "@material-ui/core/TableRow" | ||
import React from "react" | ||
|
||
export const TableLoader: React.FC = () => { | ||
const styles = useStyles() | ||
|
||
return ( | ||
<TableRow> | ||
<TableCell colSpan={999} className={styles.cell}> | ||
<Box p={4}> | ||
<CircularProgress size={26} /> | ||
</Box> | ||
</TableCell> | ||
</TableRow> | ||
) | ||
} | ||
|
||
const useStyles = makeStyles((theme) => ({ | ||
cell: { | ||
textAlign: "center", | ||
height: theme.spacing(20), | ||
}, | ||
})) |
29 changes: 29 additions & 0 deletions
29
site/src/components/TemplatesTable/TemplatesTable.stories.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
import { ComponentMeta, Story } from "@storybook/react" | ||
import React from "react" | ||
import { MockOrganization, MockTemplate } from "../../testHelpers/entities" | ||
import { TemplatesTable, TemplatesTableProps } from "./TemplatesTable" | ||
|
||
export default { | ||
title: "components/TemplatesTable", | ||
component: TemplatesTable, | ||
} as ComponentMeta<typeof TemplatesTable> | ||
|
||
const Template: Story<TemplatesTableProps> = (args) => <TemplatesTable {...args} /> | ||
|
||
export const Example = Template.bind({}) | ||
Example.args = { | ||
templates: [MockTemplate], | ||
organizations: [MockOrganization], | ||
} | ||
|
||
export const Empty = Template.bind({}) | ||
Empty.args = { | ||
templates: [], | ||
organizations: [], | ||
} | ||
|
||
export const Loading = Template.bind({}) | ||
Loading.args = { | ||
templates: undefined, | ||
organizations: [], | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
import Box from "@material-ui/core/Box" | ||
import Table from "@material-ui/core/Table" | ||
import TableBody from "@material-ui/core/TableBody" | ||
import TableCell from "@material-ui/core/TableCell" | ||
import TableHead from "@material-ui/core/TableHead" | ||
import TableRow from "@material-ui/core/TableRow" | ||
import React from "react" | ||
import { Link } from "react-router-dom" | ||
import * as TypesGen from "../../api/typesGenerated" | ||
import { CodeExample } from "../../components/CodeExample/CodeExample" | ||
import { EmptyState } from "../../components/EmptyState/EmptyState" | ||
import { TableHeaderRow } from "../../components/TableHeaders/TableHeaders" | ||
import { TableLoader } from "../../components/TableLoader/TableLoader" | ||
import { TableTitle } from "../../components/TableTitle/TableTitle" | ||
|
||
export const Language = { | ||
title: "Templates", | ||
tableTitle: "All templates", | ||
nameLabel: "Name", | ||
emptyMessage: "No templates have been created yet", | ||
emptyDescription: "Run the following command to get started:", | ||
totalLabel: "total", | ||
} | ||
|
||
export interface TemplatesTableProps { | ||
templates?: TypesGen.Template[] | ||
organizations?: TypesGen.Organization[] | ||
} | ||
|
||
export const TemplatesTable: React.FC<TemplatesTableProps> = ({ templates, organizations }) => { | ||
const isLoading = !templates || !organizations | ||
|
||
// Create a dictionary of organization ID -> organization Name | ||
// Needed to properly construct links to dive into a template | ||
const orgDictionary = | ||
organizations && | ||
organizations.reduce((acc: Record<string, string>, curr: TypesGen.Organization) => { | ||
return { | ||
...acc, | ||
[curr.id]: curr.name, | ||
} | ||
}, {}) | ||
|
||
return ( | ||
<Table> | ||
<TableHead> | ||
<TableTitle title={Language.tableTitle} /> | ||
<TableHeaderRow> | ||
<TableCell size="small">{Language.nameLabel}</TableCell> | ||
</TableHeaderRow> | ||
</TableHead> | ||
<TableBody> | ||
{isLoading && <TableLoader />} | ||
{templates && | ||
organizations && | ||
orgDictionary && | ||
templates.map((t) => ( | ||
<TableRow key={t.id}> | ||
<TableCell> | ||
<Link to={`/templates/${orgDictionary[t.organization_id]}/${t.name}`}>{t.name}</Link> | ||
</TableCell> | ||
</TableRow> | ||
))} | ||
|
||
{templates && templates.length === 0 && ( | ||
<TableRow> | ||
<TableCell colSpan={999}> | ||
<Box p={4}> | ||
<EmptyState | ||
message={Language.emptyMessage} | ||
description={Language.emptyDescription} | ||
cta={<CodeExample code="coder templates create" />} | ||
/> | ||
</Box> | ||
</TableCell> | ||
</TableRow> | ||
)} | ||
</TableBody> | ||
</Table> | ||
) | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe next time we're in here, we can break this file apart a bit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing.