feat: add autostart/autostop show, show autostart/autostop schedule in ls output #1436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1436 +/- ##
==========================================
- Coverage 67.26% 67.04% -0.23%
==========================================
Files 288 284 -4
Lines 19422 19297 -125
Branches 244 244
==========================================
- Hits 13065 12938 -127
- Misses 5019 5020 +1
- Partials 1338 1339 +1
Continue to review full report at Codecov.
|
dwahler
approved these changes
May 13, 2022
cli/autostart.go
Outdated
| } | ||
|
|
||
| if workspace.AutostartSchedule == "" { | ||
| _, _ = fmt.Fprintf(cmd.OutOrStdout(), "not enabled") |
There was a problem hiding this comment.
I think this and some of the other fmt.Fprintf calls in autostart.go and autostop.go are missing trailing newlines.
cli/autostart.go
Outdated
| return nil | ||
| } | ||
|
|
||
| _, _ = fmt.Fprintf(cmd.OutOrStdout(), "\nschedule: %s\nnext: %s\n", workspace.AutostartSchedule, validSchedule.Next(time.Now())) |
There was a problem hiding this comment.
Is there any particular reason for printing an extra blank line at the beginning?
There was a problem hiding this comment.
Probably because I yanked the line from somewhere else and forgot to clean it up 🙃
…edule in ls output
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
…n ls output (#1436) * feat: add autostart/autostop show, show autostart/autostop schedule in ls output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slipped my mind to do this before 🤦
Closes #1431