feat(coderd): enable setting max port share level during template creation #14366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
|
✅ Meticulous spotted zero visual differences across 1408 screens tested: view results. Expected differences? Click here. Last updated for commit b4ba88c. This comment will update as new commits are pushed. |
c73e535 to
fa16bf0
Compare
ethanndickson
commented
Aug 20, 2024
| @@ -329,6 +331,14 @@ func (api *API) postTemplateByOrganization(rw http.ResponseWriter, r *http.Reque | |||
| validErrs = append(validErrs, codersdk.ValidationError{Field: "autostart_requirement.days_of_week", Detail: err.Error()}) | |||
| } | |||
| } | |||
| if createTemplate.MaxPortShareLevel != nil { | |||
| err = portSharer.ValidateTemplateMaxLevel(*createTemplate.MaxPortShareLevel) | |||
There was a problem hiding this comment.
Of note is that this will always error for AGPL deployments.
deansheather
approved these changes
Aug 20, 2024
fa16bf0 to
9b5e512
Compare
9b5e512 to
b4ba88c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the max port share level could only be set during template metadata updates. It can now be set during creation, but only for enterprise deployments.
This change is most useful for the
coderdprovider, which can now set the max port share level during creation, without needing to make another request.