chore: use idiomatic test setup in notification tests #14416
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
commented
Aug 23, 2024
coderd/database/dbauthz/dbauthz.go
Outdated
Comment on lines
253
to
254
| rbac.ResourceDeploymentConfig.Type: {policy.ActionCreate, policy.ActionUpdate, policy.ActionDelete}, | ||
| rbac.ResourceNotificationTemplate.Type: {policy.ActionCreate, policy.ActionUpdate, policy.ActionDelete}, |
There was a problem hiding this comment.
These two permissions were necessary, and since tests using setupInMemory never hit dbauthz we never encountered this mismatch of permissions.
| @@ -723,19 +732,6 @@ func TestNotificationTemplatesCanRender(t *testing.T) { | |||
| }, | |||
| }, | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
This test did not belong here.
17949db to
6a28ab0
Compare
Signed-off-by: Danny Kopping <[email protected]>
6a28ab0 to
148fac8
Compare
dannykopping
commented
Aug 23, 2024
|
|
||
| // WHEN: notifications are enqueued which should succeed and fail | ||
| _, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true"}, "") // Will succeed. | ||
| _, err = enq.Enqueue(ctx, user.ID, notifications.TemplateWorkspaceDeleted, map[string]string{"nice": "true", "i": "0"}, "") // Will succeed. |
There was a problem hiding this comment.
Typical problem here: not all the business logic was in dbmem, so the pg server rejects duplicate notifications and we needed to avoid that.
mafredri
approved these changes
Aug 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking back at the tests I implemented a while back for notifications, I realized the way I was setting up the database was wrong - or at least incomplete. I'm more familiar with our testing idioms now and this was bugging me.
setupandsetupInMemoryare both covered bycoderdtest.New, depending on what theDB_FROMandDBenvironment variables are.This doesn't really change anything for tests which used
setup(since those were previously and will still provision a postgres instance to test against), but for thesetupInMemorycases it now actually tests them against a real database when we runmake test-postgres; previously they were only running in-memory.This PR also includes a couple other minor drive-by fixes, which I've called out below.