chore(cli): validate various names locally #14551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
deansheather
reviewed
Sep 4, 2024
deansheather
approved these changes
Sep 4, 2024
4fd4b55 to
5e0c568
Compare
29b527d to
01a904c
Compare
5e0c568 to
09de864
Compare
09de864 to
4bc6cfd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14544.
Closes #10244.
As mentioned in coder/terraform-provider-coderd#85,
coderddoesn't currently provide an error reason when a field in a request fails to validate. This means the CLI provides an arguably useless error message when a supplied name is invalid.Even if
coderdsupplied an error reason when a field failed to validate, the problem in #14544 would still result in a not great UX, only showing the error after a plan (which could reasonably take several minutes for some Terraform providers).I think it's okay to follow the Web UI here, and validate locally first, especially since both
coderdand the CLI will call the same validator implementation incodersdk.