Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: prefer organization display name for workspaces table #14617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

Parkreiner
Copy link
Member

@Parkreiner Parkreiner commented Sep 9, 2024

Quick fix to the organizations table. No issue to link.

With this, we defer to showing an organization's display name, and then only show the base organization name if a display name doesn't exist.

Not super obvious with Coder, but

Before (Coder is lowercase because we're using the base organization name):
Screenshot 2024-09-09 at 10 43 35 AM
After (Coder is uppercase because we do have a custom display name defined in the organization settings):
Screenshot 2024-09-09 at 10 43 28 AM

@Parkreiner Parkreiner added site Area: frontend dashboard hotfix PRs only. Harmless small change. Only humans may set this. labels Sep 9, 2024
@Parkreiner Parkreiner self-assigned this Sep 9, 2024
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@Parkreiner Parkreiner merged commit 9da6467 into main Sep 9, 2024
27 checks passed
@Parkreiner Parkreiner deleted the mes/org-name-fix branch September 9, 2024 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this. site Area: frontend dashboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant