feat!: add --default-token-lifetime#14631
Merged
ethanndickson merged 1 commit intomainfrom Sep 18, 2024
Merged
Conversation
Member
Author
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
2d3f8f4 to
5f56829
Compare
Member
|
nice. we will definitely want to label this as a breaking change in our changelog. a couple of questions?
cc @stirby as I'll be PTO for the rest of this week |
Member
Author
|
Approach changed. |
--session-duration--session-duration
--session-duration--session-duration_
--session-duration_--session-duration
Member
deansheather
approved these changes
Sep 14, 2024
5f56829 to
b691a47
Compare
--session-duration--default-token-lifetime
b691a47 to
67e03fa
Compare
67e03fa to
43477bf
Compare
deansheather
approved these changes
Sep 18, 2024
43477bf to
c969613
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #13990.
Adds a new deployment value that influences the lifetime of tokens created via:
/users/{user}/keys [post]- Used by/cli-auth/users/{user}/keys/tokens [post]- Used byTokenspage in web UI settings, andcoder tokens create.The default value of this option is 7 days, to retain the existing TTL for
/cli-authtokens.Of note is that the web UI and
coder tokens createsupply default values when calling/tokens [post].Therefore, the only breaking change in this PR is for tokens created by directly calling
/users/{user}/keys/tokens [post]without a lifetime in the request body. The default TTL for these tokens is 7 days, down from 30. Users calling this endpoint directly should already be specifying a lifetime, so this is unlikely to break any existing workflows.The tokens returned by
/users/{user}/keys [post]are still refreshed with activity, unless--disable-session-expiry-refreshis set.