Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove coderdtest dependency from codersdk #14633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Sep 10, 2024

Without this, any codersdk consumers would need to add our tailscale/gvisor go.mod replaces to run go test or go mod tidy. Of note is that go mod tidy needs to succeed for goreleaser to work, so something like the coderd provider couldn't be released.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson added the hotfix PRs only. Harmless small change. Only humans may set this. label Sep 10, 2024
@ethanndickson ethanndickson marked this pull request as ready for review September 10, 2024 10:47
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson merged commit 2a9234e into main Sep 10, 2024
34 checks passed
@ethanndickson ethanndickson deleted the 09-10-fix_remove_coderdtest_dependency_from_codersdk branch September 10, 2024 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hotfix PRs only. Harmless small change. Only humans may set this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant