feat: add warning dialog when removing member from organization #14695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc28599 to
cb6d1a6
Compare
aslilac
approved these changes
Sep 27, 2024
site/src/pages/ManagementSettingsPage/OrganizationMembersPage.tsx
Outdated
Show resolved
Hide resolved
|
|
||
| <p css={styles.test}> | ||
| Are you sure you want to remove{" "} | ||
| <strong>{memberToDelete?.username}</strong>? |
There was a problem hiding this comment.
any way we could fiddle the types so that memberToDelete isn't optional here? seeing "Are you sure you want to remove ?" would be weird
There was a problem hiding this comment.
I feels difficult to remove the undefined from memberToDelete without restructuring the pattern that ConfirmDialog uses. For now, maybe its safer to just not display the username here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #14705