Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: turn e2e enterprise tests into e2e premium tests #14979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 16, 2024
Merged

Conversation

aslilac
Copy link
Member

@aslilac aslilac commented Oct 4, 2024

  • Rename some e2e stuff from enterprise to premium
  • Shuffle secrets around for a premium license
  • Quit ignoring the results of the licensed e2e tests
  • Fix some tests that weren't passing

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 12, 2024
@matifali matifali removed the stale This issue is like stale bread. label Oct 12, 2024
@aslilac aslilac requested a review from jaaydenh October 16, 2024 17:17
@aslilac aslilac marked this pull request as ready for review October 16, 2024 17:19
// tweaking to make it work consistently (notably, ones that wait for agent
// stats on the workspace page. The default is like 50 seconds, which is
// way too long and makes it painful to wait for test runs in CI.
// actionTimeout: 5000, // 5 seconds
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be worth creating a separate issue to address this later?

Copy link
Contributor

@jaaydenh jaaydenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few questions.

@aslilac aslilac merged commit 40fb57a into main Oct 16, 2024
29 checks passed
@aslilac aslilac deleted the e2e-premium branch October 16, 2024 22:54
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants