feat: allow for different docker socket path in docker-based templates (#15035) #15049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #15035, I have tested it on my instance and it works as expected.
I have opted to default to null, that way we don't have to hardcode our own default and we let the Docker provider default to whatever it wants.
This has the downside that it makes the template a little less readable, but it has the upside that we don't have to update the default if for some reason it ever changes.
We could also do something like this, but I like it less.
I have not edited the templates that are not present in examples/templates (namely examples/jfrog/docker and examples/parameters), should I also edit these as well?
Maybe we would also want to move them to examples/templates in a separate PR?
NOTE: this PR does not cover using authenticated sources, so it's likely that only unix and tcp sockets would work out of the box but I think we don't want to include authenticated sockets OOTB (e.g SSH) because that would overcomplicate the template.
cc: @matifali