Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd): improve workspace tests #15069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2024
Merged

fix(coderd): improve workspace tests #15069

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64be8c9
fix: coderd workspace tests
defelmnq Oct 14, 2024
ea2a20c
fix: coderd workspace tests
defelmnq Oct 14, 2024
74d5e9f
fix: coderd workspace tests
defelmnq Oct 14, 2024
583d1a3
fix: coderd workspace tests
defelmnq Oct 14, 2024
deeb101
fix: coderd workspace tests
defelmnq Oct 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions coderd/workspacebuilds_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1183,9 +1183,8 @@ func TestPostWorkspaceBuild(t *testing.T) {
})
}

//nolint:paralleltest
func TestWorkspaceBuildTimings(t *testing.T) {
t.Parallel()

// Setup the test environment with a template and version
db, pubsub := dbtestutil.NewDB(t)
client := coderdtest.New(t, &coderdtest.Options{
Expand Down Expand Up @@ -1239,9 +1238,8 @@ func TestWorkspaceBuildTimings(t *testing.T) {
})
}

//nolint:paralleltest
t.Run("NonExistentBuild", func(t *testing.T) {
t.Parallel()

// When: fetching an inexistent build
buildID := uuid.New()
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
Expand All @@ -1253,9 +1251,8 @@ func TestWorkspaceBuildTimings(t *testing.T) {
require.Contains(t, err.Error(), "not found")
})

//nolint:paralleltest
t.Run("EmptyTimings", func(t *testing.T) {
t.Parallel()

// When: fetching timings for a build with no timings
build := makeBuild()
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
Expand All @@ -1268,9 +1265,8 @@ func TestWorkspaceBuildTimings(t *testing.T) {
require.Empty(t, res.AgentScriptTimings)
})

//nolint:paralleltest
t.Run("ProvisionerTimings", func(t *testing.T) {
t.Parallel()

// When: fetching timings for a build with provisioner timings
build := makeBuild()
provisionerTimings := dbgen.ProvisionerJobTimings(t, db, build, 5)
Expand All @@ -1295,9 +1291,8 @@ func TestWorkspaceBuildTimings(t *testing.T) {
}
})

//nolint:paralleltest
t.Run("AgentScriptTimings", func(t *testing.T) {
t.Parallel()

// When: fetching timings for a build with agent script timings
build := makeBuild()
resource := dbgen.WorkspaceResource(t, db, database.WorkspaceResource{
Expand Down Expand Up @@ -1329,9 +1324,8 @@ func TestWorkspaceBuildTimings(t *testing.T) {
}
})

//nolint:paralleltest
t.Run("NoAgentScripts", func(t *testing.T) {
t.Parallel()

// When: fetching timings for a build with no agent scripts
build := makeBuild()
resource := dbgen.WorkspaceResource(t, db, database.WorkspaceResource{
Expand All @@ -1350,16 +1344,16 @@ func TestWorkspaceBuildTimings(t *testing.T) {
})

// Some workspaces might not have agents. It is improbable, but possible.
//nolint:paralleltest
t.Run("NoAgents", func(t *testing.T) {
t.Parallel()

// When: fetching timings for a build with no agents
build := makeBuild()
dbgen.WorkspaceResource(t, db, database.WorkspaceResource{
JobID: build.JobID,
})

// Then: return a response with empty agent script timings
// trigger build
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitLong)
t.Cleanup(cancel)
res, err := client.WorkspaceBuildTimings(ctx, build.ID)
Expand Down
Loading