Hi @toshikish, thank you for the contribution. Could you rebase your PR on main and make all the checks in CI pass? We should be able to review the contribution after that.

@matifali Hi, thank you for reviewing. I rebased the branch and fixed the lint and unit test errors found so far.

The cause of test-e2e-premium failure is that license is empty.
https://github.com/coder/coder/actions/runs/11565755422/job/32199523539?pr=15182#step:11:131

The environment variable CODER_E2E_LICENSE seems substituted through CI secret, but is it set correctly?
https://github.com/toshikish/coder/blob/set-min-max-for-workspace-parameters/.github/workflows/ci.yaml#L616

The cause of test-e2e-premium failure is that license is empty. coder/coder/actions/runs/11565755422/job/32199523539?pr=15182#step:11:131

The environment variable CODER_E2E_LICENSE seems substituted through CI secret, but is it set correctly? toshikish/coder@set-min-max-for-workspace-parameters/.github/workflows/ci.yaml#L616

Yes, it is, but unfortunately, the secret is not available on PRs made through branches outside of coder/coder.

I think rebasing this PR from main should fix the e2e tests.

@BrunoQuaresma unfortunately e2e tests can't work on forks as they don't have access to the repo secrets (the license).

Also we can't allow forks to have access to secrets in a safe way.

@BrunoQuaresma COuld we run the e2e tests locally while we figure out a way to allow forks to run them?

@BrunoQuaresma Could you review it again? Thanks

@matifali the code didn't change from my last review so I think we are ready to go. My only concern is not being able to run the e2e tests using the premium license.

@matifali', the code didn't change from my last review,' so I think we are ready to go. My only concern is not being able to run the e2e tests using the premium license.

Can we run them locally and approve if they pass, and force merge? We are tracking e2e tests for forks in #15557

@matifali Sure, I just don't have permission to force a merge. We have integration tests for this so I think we are safe to merge it right now. If it breaks something in the main, I can jump on it right away.