fix: ensure make gen runs on any changes
#15253
Conversation
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ethanndickson and the rest of your teammates on |
d23f235 to
a2a3e04
Compare
a2a3e04 to
8ee58ff
Compare
| needs: changes | ||
| if: needs.changes.outputs.docs-only == 'true' || needs.changes.outputs.ci == 'true' || github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
I think we can just remove the if and needs both. always() is used when we want to run even if the previous job fails.
There was a problem hiding this comment.
I think it's worth making it explicit here, it seems quite difficult to find the documentation that says the default condition is always() and not success().
There was a problem hiding this comment.
The default is success(), I think. Why do we need always()?
There was a problem hiding this comment.
The old condition didn't check if the previous job had succeeded (it just waited for changes to finish, which always succeeded) so I don't think we need to start checking it now. My understanding is that with success() gen CI wouldn't run if lint failed? Which would mean it would wait for lint to finish, when they could just be started concurrently (especially since gen is one of the faster jobs). Please correct me if I'm wrong.
Previously,
make genran on CI whenever a non-docs change was made. Based off the problem described in #15252, it sounds like CI should always be runninggen.(Because I broke it, currently PR
genis getting skipped unless thecicategory is updated)