Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix security workflow not installing protoc properly #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 29, 2024
Merged

fix: fix security workflow not installing protoc properly #15263

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
40120aa
fix: fix security workflow not installing protoc properly
sreya Oct 29, 2024
94efa16
fix(security): quote path to handle special chars
sreya Oct 29, 2024
42acbe9
Fix include path in Docker copy command
sreya Oct 29, 2024
6a6ab5c
Fix permission command in 'security.yaml' workflow
sreya Oct 29, 2024
484d041
Remove unused chown command in security workflow
sreya Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/security.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ name: "security"
permissions:
actions: read
contents: read
security-events: write

on:
workflow_dispatch:
Expand All @@ -23,6 +22,8 @@ concurrency:

jobs:
codeql:
permissions:
security-events: write
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
steps:
- name: Harden Runner
Expand Down Expand Up @@ -61,6 +62,8 @@ jobs:
"${{ secrets.SLACK_SECURITY_FAILURE_WEBHOOK_URL }}"

trivy:
permissions:
security-events: write
runs-on: ${{ github.repository_owner == 'coder' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
steps:
- name: Harden Runner
Expand Down Expand Up @@ -95,13 +98,20 @@ jobs:
# protoc must be in lockstep with our dogfood Dockerfile or the
# version in the comments will differ. This is also defined in
# ci.yaml.
set -x
set -euxo pipefail
cd dogfood/contents
mkdir -p /usr/local/bin
mkdir -p /usr/local/include

DOCKER_BUILDKIT=1 docker build . --target proto -t protoc
protoc_path=/usr/local/bin/protoc
docker run --rm --entrypoint cat protoc /tmp/bin/protoc > $protoc_path
chmod +x $protoc_path
protoc --version
# Copy the generated files to the include directory.
docker run --rm -v /usr/local/include:/target protoc cp -r /tmp/include/google /target/
ls -la /usr/local/include/google/protobuf/
stat /usr/local/include/google/protobuf/timestamp.proto

- name: Build Coder linux amd64 Docker image
id: build
Expand Down