Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: create ResourceNotificationMessage and AsNotifier #15301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 31, 2024
Merged

chore: create ResourceNotificationMessage and AsNotifier #15301

merged 5 commits into from
Oct 31, 2024

Conversation

DanielleMaywood
Copy link
Contributor

@DanielleMaywood DanielleMaywood commented Oct 31, 2024 •
edited
Loading

Closes #15213

This PR enables sending notifications without requiring the auth system context, instead using a new auth notifier context.

@DanielleMaywood DanielleMaywood marked this pull request as ready for review October 31, 2024 14:18
mafredri
mafredri approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'll defer to @johnstcn or @Emyrk for final approval for all things RBAC 😄

@DanielleMaywood DanielleMaywood requested a review from Emyrk October 31, 2024 14:28
dannykopping
dannykopping approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for adding this 👍

@DanielleMaywood DanielleMaywood merged commit 330acd1 into main Oct 31, 2024
28 of 30 checks passed
@DanielleMaywood DanielleMaywood deleted the dm-as-notifier branch October 31, 2024 17:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dannykopping dannykopping dannykopping approved these changes

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@DanielleMaywood DanielleMaywood

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chore(rbac): add dbauthz.AsNotifier
3 participants
@DanielleMaywood @mafredri @dannykopping