fix: workspaces query to correctly user username from users table #15305
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15302
The subquery on the users table was incorrectly using the username from the
workspaces
table, not theusers
table.This passed
sqlc-vet
because the column did exist in the query, it just was not the correct one.Note: If we do not care about
deleted
users, we can drop querying theUsers
table at all and use theowner_username
on the workspaces. But then we'd get deleted users with the same name 😢