Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: support postgresql connection via individual flags #15379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joobisb wants to merge 9 commits into from
Closed

feat: support postgresql connection via individual flags #15379

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9bc7b28
feat: support postgresql connection via individual flags
joobisb Nov 5, 2024
5deb4da
fix: updated golden file
joobisb Nov 5, 2024
31b3b9b
fix: addressed review comments
joobisb Nov 6, 2024
8574592
updated docs
joobisb Nov 6, 2024
bfa3cb2
fix: appropriate error message
joobisb Nov 6, 2024
f50963b
make gen
joobisb Nov 13, 2024
7e8573c
return bool from validatePostgresFlags
joobisb Nov 15, 2024
b3c396b
Merge branch 'main' into issue#15264
mafredri Nov 15, 2024
a15c797
Merge branch 'main' into issue#15264
mafredri Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated docs
  • Loading branch information
@joobisb
joobisb committed Nov 6, 2024
commit 85745920be643635a00669039289e8d7d95525a2
3 changes: 2 additions & 1 deletion cli/testdata/coder_server_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ OPTIONS:
provided via other flags, PostgreSQL binaries will be downloaded from
Maven (https://repo1.maven.org/maven2) and store all data in the
config root. Access the built-in database with "coder server
postgres-builtin-url".
postgres-builtin-url". This can't be used together with individual
postgres connection flags.

--postgres-database string, $CODER_PG_DATABASE
PostgreSQL database name.
Expand Down
2 changes: 1 addition & 1 deletion codersdk/deployment.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2257,7 +2257,7 @@ when required by your organization's security policy.`,
},
{
Name: "Postgres Connection URL",
Description: "URL of a PostgreSQL database. If empty and credentials are not provided via other flags, PostgreSQL binaries will be downloaded from Maven (https://repo1.maven.org/maven2) and store all data in the config root. Access the built-in database with \"coder server postgres-builtin-url\".",
Description: "URL of a PostgreSQL database. If empty and credentials are not provided via other flags, PostgreSQL binaries will be downloaded from Maven (https://repo1.maven.org/maven2) and store all data in the config root. Access the built-in database with \"coder server postgres-builtin-url\". This can't be used together with individual postgres connection flags.",
Flag: "postgres-url",
Env: "CODER_PG_CONNECTION_URL",
Annotations: serpent.Annotations{}.Mark(annotationSecretKey, "true"),
Expand Down
7 changes: 6 additions & 1 deletion docs/reference/cli/server.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion enterprise/cli/testdata/coder_server_--help.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ OPTIONS:
provided via other flags, PostgreSQL binaries will be downloaded from
Maven (https://repo1.maven.org/maven2) and store all data in the
config root. Access the built-in database with "coder server
postgres-builtin-url".
postgres-builtin-url". This can't be used together with individual
postgres connection flags.

--postgres-database string, $CODER_PG_DATABASE
PostgreSQL database name.
Expand Down