Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: use NoLock dbmem subqueries for GetWorkspaceAgentScriptTimingsByBuildID #15405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

fix: use NoLock dbmem subqueries for GetWorkspaceAgentScriptTimingsByBuildID #15405

merged 1 commit into from
Nov 6, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Nov 6, 2024 •
edited
Loading

Closes coder/internal#202.

Addresses the problem mentioned in the issue, and also makes sure subtests don't reuse testing.T from the main test.

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson marked this pull request as ready for review November 6, 2024 11:41
cdr-bot[bot]
cdr-bot bot approved these changes Nov 6, 2024
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is a hotfix and has been automatically approved.

  • ✅ Base is main or release branch
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ✅ Less than 100 lines

@ethanndickson ethanndickson enabled auto-merge (squash) November 6, 2024 11:42
@ethanndickson ethanndickson force-pushed the ethan/fix-timings-flake branch from 2c24dd6 to e2e8d74 Compare November 6, 2024 12:23
@ethanndickson ethanndickson changed the title fix: avoid sharing t in TestWorkspaceBuildTimings fix: use NoLock dbmem subqueries for GetWorkspaceAgentScriptTimingsByBuildID Nov 6, 2024
@ethanndickson ethanndickson force-pushed the ethan/fix-timings-flake branch from e2e8d74 to ba8e8cd Compare November 6, 2024 12:29
mtojek
mtojek approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ethanndickson ethanndickson enabled auto-merge (squash) November 6, 2024 12:39
@ethanndickson ethanndickson merged commit f0a4de5 into main Nov 6, 2024
27 checks passed
@ethanndickson ethanndickson deleted the ethan/fix-timings-flake branch November 6, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtojek mtojek mtojek approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] approved these changes

@spikecurtis spikecurtis Awaiting requested review from spikecurtis

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flake: GetWorkspaceAgentScriptTimingsByBuildID can deadlock with dbmem
2 participants
@ethanndickson @mtojek