fix: use container with Postgres 13 for dump.sql #15411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It only starts a new pg 13 container on a random port and then cleans it up. Doesn't affect other containers. |
Emyrk
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes from #15336 made the
coderd/database/gen/dump/main.goscript used bymake genconnect to the Postgres container running at localhost:5432 if it was available. Previously a new Postgres 13 container would be created every time.This is annoying during development - if you're running a Postgres 16 container in the background you'll get a different
dump.sqlthan with Postgres 13. This PR reverts the script to create a fresh Postgres 13 container on each run.