Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: support adding dns hosts to tailnet.Conn #15419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Nov 7, 2024

Relates to #14718.

The remaining changes (regarding the Tailscale DNS service) will need to be made on coder/tailscale.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ethanndickson and the rest of your teammates on Graphite Graphite

@ethanndickson ethanndickson force-pushed the ethan/conn-dns branch 4 times, most recently from 2afde49 to b5ea3af Compare November 7, 2024 09:39
@ethanndickson ethanndickson marked this pull request as ready for review November 7, 2024 10:13
@ethanndickson ethanndickson force-pushed the ethan/conn-dns branch 2 times, most recently from fe630cd to e4c3c63 Compare November 8, 2024 07:56
Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small gotcha about the addresses you use in your tests, but I don't need to review again.

@ethanndickson ethanndickson enabled auto-merge (squash) November 8, 2024 09:30
@ethanndickson ethanndickson merged commit 5d853fc into main Nov 8, 2024
27 checks passed
@ethanndickson ethanndickson deleted the ethan/conn-dns branch November 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants