chore: move organizatinon sync to runtime configuration #15431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Nov 7, 2024
Comment on lines
-36
to
+37
| // NoActorError wraps ErrNoRows for the api to return a 404. This is the correct | ||
| // response when the user is not authorized. | ||
| var NoActorError = xerrors.Errorf("no authorization actor in context: %w", sql.ErrNoRows) | ||
| // NoActorError is returned if no actor is present in the context. | ||
| var NoActorError = xerrors.Errorf("no authorization actor in context") |
There was a problem hiding this comment.
This error was being disguised as a ErrNoRows, but no actor is a fatal error and should be raised as such.
f0ssel
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes coder/internal#86
Moves the configuration from environment to database backed, to allow configuring
organization sync at runtime.
Cli PR will be a follup.