Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(agent/reconnectingpty): generate rpty id before starting lifecycle #15475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix(agent/reconnectingpty): generate rpty id before starting lifecycle #15475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(agent/reconnectingpty): generate rpty id before starting lifecycle
  • Loading branch information
@johnstcn
johnstcn committed Nov 11, 2024
commit abacf8db1cac8a32745d3b68cf809d74cf5d5637
4 changes: 2 additions & 2 deletions agent/reconnectingpty/screen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,6 @@ func newScreen(ctx context.Context, cmd *pty.Cmd, options *Options, logger slog.
timeout: options.Timeout,
}

go rpty.lifecycle(ctx, logger)

// Socket paths are limited to around 100 characters on Linux and macOS which
// depending on the temporary directory can be a problem. To give more leeway
// use a short ID.
Expand All @@ -80,6 +78,8 @@ func newScreen(ctx context.Context, cmd *pty.Cmd, options *Options, logger slog.
}
rpty.id = hex.EncodeToString(buf)

go rpty.lifecycle(ctx, logger)

settings := []string{
// Disable the startup message that appears for five seconds.
"startup_message off",
Expand Down
Loading