Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: More robust provisionersdk agent init scripts #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 19, 2022
Merged

fix: More robust provisionersdk agent init scripts #1551

merged 5 commits into from
May 19, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented May 18, 2022 •
edited
Loading

This PR makes the provisionersdk agent init scripts a bit more robust (mostly on Linux).

  • Try wget and busybox wget instead of just curl
  • More verbose shell output via -x
  • Handle mktemp limitation on busybox by adding one X in template

Related #1544

Tested on:

  • alpine:latest
  • codercom/enterprise-base:ubuntu

@mafredri mafredri self-assigned this May 18, 2022
@mafredri mafredri requested review from johnstcn and a team May 18, 2022 14:24
kylecarbs
kylecarbs approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooooo very nice!

deansheather
deansheather approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any usages of quotes should be surrounded in quotes IMO (except for the variable setting case when not using export)

johnstcn
johnstcn approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@mafredri mafredri enabled auto-merge (squash) May 19, 2022 12:51
@mafredri mafredri merged commit ad9bdb7 into main May 19, 2022
@mafredri mafredri deleted the mafredri/improve-provisionersdk-agent-scripts branch May 19, 2022 13:02
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@mafredri @deansheather @kylecarbs
fix: More robust provisionersdk agent init scripts (#1551)
b6b0aaf 
Related #1544

Co-authored-by: Dean Sheather <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

@johnstcn johnstcn johnstcn approved these changes

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mafredri @johnstcn @kylecarbs @deansheather