Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix tailnet resume using incorrect DB reference #15522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix: fix tailnet resume using incorrect DB reference #15522

merged 1 commit into from
Nov 18, 2024

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Nov 14, 2024

  • We were instantiating a cryptokey cache with a vanilla reference to the database instead of one wrapped by dbcrypt.
  • Fixes an issue where failing to instantiate unrelated keycaches does not fatally error out.

@sreya
fix: fix tailnet resume using incorrect DB reference
52ff23d 
- We were instantiating a cryptokey cache with a vanilla reference
  to the database instead of one wrapped by dbcrypt.
- Fixes an issue where failing to instantiate unrelated keycaches
  does not fatally error out.
ethanndickson
ethanndickson approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@ethanndickson ethanndickson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since we spoke about the issue 🎉

@sreya sreya merged commit 48bb452 into main Nov 18, 2024
27 checks passed
@sreya sreya deleted the jon/fixresume branch November 18, 2024 20:09
sreya added a commit that referenced this pull request Nov 18, 2024
@sreya
fix: fix tailnet resume using incorrect DB reference (#15522)
6d761a8 
- We were instantiating a cryptokey cache with a vanilla reference to
the database instead of one wrapped by dbcrypt.
- Fixes an issue where failing to instantiate unrelated keycaches does
not fatally error out.
sreya added a commit that referenced this pull request Nov 18, 2024
@sreya
fix: fix tailnet resume using incorrect DB reference (#15522) (#15574)
dbfadf2 
- We were instantiating a cryptokey cache with a vanilla reference to
the database instead of one wrapped by dbcrypt.
- Fixes an issue where failing to instantiate unrelated keycaches does
not fatally error out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanndickson ethanndickson ethanndickson approved these changes

Assignees

@sreya sreya

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @ethanndickson