Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(examples/templates/gcp-linux): add GCP region, code-server and JetBrains Gateway modules #15550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 28, 2024
Merged

feat(examples/templates/gcp-linux): add GCP region, code-server and JetBrains Gateway modules #15550

merged 3 commits into from
Nov 28, 2024
+46 −63

Conversation

phorcys420
Copy link
Member

@phorcys420 phorcys420 commented Nov 16, 2024 •
edited
Loading

This PR adds the GCP region, code-server and JetBrains Gateway modules.

  • Testing
    • Workspace gets provisioned and region selector works
    • code-server works as intended
    • JetBrains gateway works as intended

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 24, 2024
@phorcys420
Copy link
Member Author

Works as intended, had to set a default region for the plan step to not fail.
Available on dogfood @ https://dev.coder.com/templates/coder/gcp-linux/versions/promote-modules-pr-1053

@phorcys420 phorcys420 marked this pull request as ready for review November 27, 2024 00:09
@phorcys420 phorcys420 changed the title feat(examples/templates/gcp-linux): promote modules feat(examples/templates/gcp-linux): add GCP region, code-server and JetBrains Gateway modules Nov 27, 2024
@phorcys420 phorcys420 enabled auto-merge (squash) November 27, 2024 00:10
@github-actions github-actions bot removed the stale This issue is like stale bread. label Nov 28, 2024
matifali
matifali approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@matifali matifali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@phorcys420 phorcys420 merged commit 946328f into main Nov 28, 2024
27 checks passed
@phorcys420 phorcys420 deleted the phorcys/promote-modules-gcp-linux branch November 28, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matifali matifali matifali approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@phorcys420 phorcys420

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phorcys420 @matifali