Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(cli): properly handle build log streaming during coder ping #15600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 20, 2024
Merged

fix(cli): properly handle build log streaming during coder ping #15600

merged 1 commit into from
Nov 20, 2024

Conversation

ethanndickson
Copy link
Member

@ethanndickson ethanndickson commented Nov 20, 2024 •
edited
Loading

Closes #15584.

  • The Collecting Diagnostics spinner now starts after the workspace build logs (if any) have finished streaming.
  • Removes network interfaces with negative MTUs from healthsdk diagnostics.
  • Improves the wording on diagnostics for MTUs below the 'safe' value to indicate that direct connections may be degraded, or rendered unusable (i.e. if every packet is dropped).

@ethanndickson Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@ethanndickson ethanndickson marked this pull request as ready for review November 20, 2024 03:27
@ethanndickson ethanndickson merged commit 6e7f65b into main Nov 20, 2024
35 checks passed
@ethanndickson ethanndickson deleted the ethan/ping-cleanup branch November 20, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@ethanndickson ethanndickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ping command diagnostics gets interleaved with build log output
2 participants
@ethanndickson @deansheather