chore: fix more flaky tests on Windows with Postgres #15629
Merged
+32
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Nov 26, 2024
coderd/database/dbgen/dbgen.go
Outdated
| }) | ||
| require.NoError(t, err, "insert workspace agent script") | ||
| return timing | ||
| for i := 0; i < 2500; i++ { |
There was a problem hiding this comment.
I'm guessing you didn't mean to add leave this loop
There was a problem hiding this comment.
2500 retries was a little excessive, lowered it to 10
Comment on lines
+10
to
+13
| WaitShort = 30 * time.Second | ||
| WaitMedium = 40 * time.Second | ||
| WaitLong = 70 * time.Second | ||
| WaitSuperLong = 240 * time.Second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following flakes:
I temporarily enabled CI with Windows/PG in a previous commit and re-run it 3 times. It passed 3 times in a row: https://github.com/coder/coder/actions/runs/12012729874/job/33489594597