fix(coderd): extract provisionerdserver.StaleInterval to 90 seconds #15643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
reviewed
Nov 25, 2024
mafredri
approved these changes
Nov 25, 2024
SasSwart
reviewed
Nov 26, 2024
|
|
||
| // StaleInterval is the amount of time after the last heartbeat for which | ||
| // the provisioner will be reported as 'stale'. | ||
| StaleInterval = 90 * time.Second |
There was a problem hiding this comment.
If I configure my heartbeat interval to be greater than 90 sec, it reads like this will introduce false negatives where a heartbeat simply hasn't run but the provisioner presents as stale. Am I missing something?
There was a problem hiding this comment.
Yep, but we don't expose that as a coderd configuration knob yet. The only way you could configure that is by editing the source code right now.
johnstcn
added a commit
that referenced
this pull request
Dec 12, 2024
johnstcn
added a commit
that referenced
this pull request
Dec 12, 2024
johnstcn
added a commit
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #15578
Extracts
provisionerdserver.StaleIntervaland sets it to 90 seconds by default