Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add RBAC to /workspace endpoints #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 18, 2022
Merged

feat: Add RBAC to /workspace endpoints #1566

merged 10 commits into from
May 18, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented May 18, 2022 •
edited
Loading

Added routes:

"GET:/api/v2/workspaceresources/{workspaceresource}"
"GET:/api/v2/workspacebuilds/{workspacebuild}"
"GET:/api/v2/workspacebuilds/{workspacebuild}/logs":
"GET:/api/v2/workspacebuilds/{workspacebuild}/resources":
"GET:/api/v2/workspacebuilds/{workspacebuild}/state":
"PATCH:/api/v2/workspacebuilds/{workspacebuild}/cancel":
"GET:/api/v2/workspaces/{workspace}/builds/{workspacebuildname}"
"GET:/api/v2/users/oauth2/github/callback":
"POST:/api/v2/users/{user}/organizations":
"GET:/api/v2/workspaces/{workspace}"
"PUT:/api/v2/workspaces/{workspace}/autostart":
"PUT:/api/v2/workspaces/{workspace}/autostop":
"GET:/api/v2/workspaces/{workspace}/builds":
"POST:/api/v2/workspaces/{workspace}/builds":

kylecarbs
kylecarbs approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. Just to triple check, this still permits admins to view all workspaces, right?

@Emyrk
Copy link
Member Author

Emyrk commented May 18, 2022

Seems reasonable. Just to triple check, this still permits admins to view all workspaces, right?

Yup! I need to make another unit test that will provably assert this kind of thing. I will get to that next.

@Emyrk Emyrk merged commit c034e83 into main May 18, 2022
@Emyrk Emyrk deleted the stevenmasley/rbac_org_endpoints branch May 18, 2022 23:15
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@Emyrk @kylecarbs
feat: Add RBAC to /workspace endpoints (#1566)
544ee9b 
* feat: Add RBAC to /workspace endpoints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Emyrk @kylecarbs