feat: allow old GitHub names #15730
Closed
feat: allow old GitHub names #15730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The regex for the frontend in site/src/utils/formUtils.ts also needs to be updated.
The end-to-end tests then pass for a user named admin-, so it doesn't look like this would break any core workflows.
Do we know why GitHub started rejecting names with trailing hyphens? Is it any of concern to us?
|
This will break subdomain parsing for workspace apps in Coder. We should probably just attempt to trim the invalid characters when creating a new user for the GitHub account. Our subdomains use the form |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people have old names that could include a trailing hyphen, like mine:
Chagui-This PR allows them to use coder, instead of getting this error on login:
'in tx: execute transaction: create user: invalid username "Chagui-": must be alphanumeric with hyphens'The error already doesn't say anything about no trailing hyphens, so no change is needed there.