fix: static data in mocks #1574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
May 18, 2022
Kira-Pilot
approved these changes
May 18, 2022
This fixes Storybook, not breaks it. To understand why not have dynamic is causing a changeset in chromatic: https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=628544a245901b004586ba74 |
|
@vapurrmaid I believe this will fix that page, but break the Workspaces page timestamps in Storybook. |
|
@vapurrmaid it's probably best if Storybook page instances decide to use static vs. dynamic time themselves. Because there could be requirements to display |
greyscaled
commented
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.