Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Use Terraform address to index resource + agent association #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2022
Merged

fix: Use Terraform address to index resource + agent association #1577

merged 1 commit into from
May 18, 2022

Conversation

kylecarbs
Copy link
Member

This fixes resources created from Terraform modules not
properly being associated with an agent.

By not using the address, and resource identifiers prefixed
with module.<name> would be missed!

@kylecarbs
fix: Use Terraform address to index resource + agent association
d5dbb0e 
This fixes resources created from Terraform modules not
properly being associated with an agent.

By not using the address, and resource identifiers prefixed
with `module.<name>` would be missed!
@kylecarbs kylecarbs requested a review from Emyrk May 18, 2022 20:44
@kylecarbs kylecarbs self-assigned this May 18, 2022
@kylecarbs kylecarbs requested a review from coadler May 18, 2022 21:07
@kylecarbs kylecarbs merged commit f3fe2a0 into main May 18, 2022
@kylecarbs kylecarbs deleted the tfmodresources branch May 18, 2022 21:26
johnstcn added a commit that referenced this pull request May 19, 2022
@johnstcn
Revert "fix: Use Terraform address to index resource + agent associat…
89e8160 
…ion (#1577)"

This reverts commit f3fe2a0.
@johnstcn johnstcn mentioned this pull request May 19, 2022
Merged
johnstcn added a commit that referenced this pull request May 19, 2022
@johnstcn
Revert "fix: Use Terraform address to index resource + agent associat…
8814cb0 
…ion (#1577)" (#1585)

This reverts commit f3fe2a0.
@kylecarbs kylecarbs mentioned this pull request May 24, 2022
Closed
kylecarbs added a commit that referenced this pull request May 24, 2022
@kylecarbs
fix: Use Terraform address to index resource + agent association
9963149 
Closes #1705.

There was an issue in the implementation brought by #1577 by not trimming
the array value when resources use counts. This should fix it, and adds
a test to be sure!
@kylecarbs kylecarbs mentioned this pull request May 24, 2022
Merged
kylecarbs added a commit that referenced this pull request May 25, 2022
@kylecarbs
fix: Use Terraform address to index resource + agent association (#1727)
74329f4 
Closes #1705.

There was an issue in the implementation brought by #1577 by not trimming
the array value when resources use counts. This should fix it, and adds
a test to be sure!
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use Terraform address to index resource + agent association (#1577)
1abdb78 
This fixes resources created from Terraform modules not
properly being associated with an agent.

By not using the address, and resource identifiers prefixed
with `module.<name>` would be missed!
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@johnstcn @kylecarbs
Revert "fix: Use Terraform address to index resource + agent associat…
9164618 
…ion (#1577)" (#1585)

This reverts commit f3fe2a0.
kylecarbs added a commit that referenced this pull request Jun 10, 2022
@kylecarbs
fix: Use Terraform address to index resource + agent association (#1727)
5928791 
Closes #1705.

There was an issue in the implementation brought by #1577 by not trimming
the array value when resources use counts. This should fix it, and adds
a test to be sure!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coadler coadler coadler approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@kylecarbs kylecarbs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kylecarbs @coadler