Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: adopt markdownlint and markdown-table-formatter for *.md #15831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adopt markdownlint and markdown-table-formatter for *.md #15831
Changes from all commits
fe34c79
5d1429a
a8b2217
8df4ea1
819074c
150fdef
4a1fb29
acee64b
9109a7e
a6b8f83
6e8aa60
9f14438
40a94f1
43435a5
1da5f23
59a92c9
34ca8cb
4dc14ea
b7331df
fcaa917
e9431a6
2f84e0f
e3ac0b1
9ccfcfd
7d5b411
3b396d3
44ceda1
847a8f3
4ed47fc
89fec9a
6d5006a
0471071
981d7b5
d11102a
e14d543
f1305d0
3670fa7
e1eec2f
f3652f7
34ceccf
868d3fa
3c2c4da
8cdd668
223cd4d
6de5e1d
2ed285f
eb3504c
7b7308b
95d5574
d8fb439
db200bb
60a5a4a
691cf5c
c9afb8b
79abf5f
7a326bd
f6c652a
ab64ced
fd042dd
c9bc320
a38312a
3417860
bd31583
9b0f28a
917d6b3
ad73e4e
90acaca
979a283
34aa71b
6abc05a
a291686
a61d20d
e384d0a
f0cb88d
4e83922
504a1ed
4cea376
1637783
5392bb7
15f21eb
b733ad1
0d41834
f97ce22
687b015
fe265eb
33f4b81
11dd374
43f568b
dadc689
c375423
6b95860
8fefeef
8731666
9f6adaa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works now but could at some point fail with a shell error: argument list too long. Using xargs is one option and maybe markdown-lint has some other built-in function.
If a file has spaces that would also be problematic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as before, you could just add xargs in front of pnpm here. You could use null instead of newline (
tr , ’\0’
,xargs -0
) for additional safety. For ultimate safety, store files in env via yaml and echo the env in addition to null handling and all bases are covered.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this - seems like it might make it easier to debug issues later too
something like a commented out debug line that writes the env contents into a file? is that possible/useful?
I'm not sure what it would specifically look like or if it's a
cat
orecho
(printf
?) thing, but something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mafredri I am leaving the suggestions here out of this PR. I need to learn the risks here and can address them in a follow-up PR. I also welcome you taking a jab at this.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do our replacement commands obey
.gitignore
now that we don't use prettier/.prettierignore
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the formatting is done by
biome
and it supports.gitignore
. I need to configure it though.See: https://biomejs.dev/reference/configuration/#vcsuseignorefile