Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): remove a misplaced warning banner in the frontend #15837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 12, 2024
Merged

fix(site): remove a misplaced warning banner in the frontend #15837

merged 2 commits into from
Dec 12, 2024

Conversation

SasSwart
Copy link
Contributor

@SasSwart SasSwart commented Dec 11, 2024 •
edited
Loading

This PR fixes some faulty frontend logic that was introduced in #15686

@SasSwart SasSwart changed the title Don't show provisioner warnings for running workspaces fix(site): remove a misplaced warning banner in the frontend Dec 12, 2024
@SasSwart SasSwart requested review from sreya and johnstcn December 12, 2024 10:00
@SasSwart SasSwart marked this pull request as ready for review December 12, 2024 10:00
johnstcn
johnstcn approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock.

@SasSwart SasSwart merged commit 0e98c0e into main Dec 12, 2024
38 checks passed
@SasSwart SasSwart deleted the jjs/provisioner-warnings branch December 12, 2024 15:25
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@sreya sreya Awaiting requested review from sreya

Assignees

@SasSwart SasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SasSwart @johnstcn