feat: Add create workspace page #1589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the frontend to render inputs displaying these values!
Co-authored-by: Cian Johnston <[email protected]>
kylecarbs
commented
May 19, 2022
kylecarbs
commented
May 19, 2022
kylecarbs
commented
May 19, 2022
| id: "templateState", | ||
| initial: "gettingOrganizations", | ||
| states: { | ||
| gettingOrganizations: { |
There was a problem hiding this comment.
I see gettingOrganizations, gettingTemplate, gettingTemplateVersion, and gettingTemplateSchema are chained which can make the load time noticeable. If it is a problem, I think it is ok for now, we can make them parallel states.
There was a problem hiding this comment.
I wasn't sure how to make it parallel, is there another file I can reference for example?
There was a problem hiding this comment.
site/src/pages/CreateWorkspacePage/CreateWorkspacePage.test.tsx
Outdated
Show resolved
Hide resolved
BrunoQuaresma
approved these changes
May 19, 2022
|
I made some QA and it works well for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page certainly needs some visual love, but I'll add that in another PR. This implements the core functionality for creating a workspace via the UI.
Things to be added in the future:
readmeproperty on a template version)