Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: add new scaling doc to best practices section #15904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Jan 21, 2025
Merged

Conversation

EdwardAngert
Copy link
Contributor

@EdwardAngert EdwardAngert commented Dec 17, 2024

@EdwardAngert EdwardAngert added the docs Area: coder.com/docs label Dec 17, 2024
@EdwardAngert EdwardAngert self-assigned this Dec 17, 2024
@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 31, 2024
@github-actions github-actions bot closed this Jan 3, 2025
@EdwardAngert EdwardAngert reopened this Jan 3, 2025
@EdwardAngert EdwardAngert removed the stale This issue is like stale bread. label Jan 3, 2025
@EdwardAngert EdwardAngert marked this pull request as ready for review January 9, 2025 19:49

### Scaling

Coder Server can be scaled both vertically for bigger instances and horizontally
Copy link
Contributor Author

@EdwardAngert EdwardAngert Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericpaulsen you had mentioned linking to the replica & resources values in our Helm chart

is that this section of coder-observability/values.yaml?

Copy link
Contributor

@spikecurtis spikecurtis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some inline comments, but I don't need to review again.

- Capture infrastructure metrics like CPU, memory, open files, and network I/O for all
Coder Server, external provisioner daemon, workspace proxy, and PostgreSQL instances.

### Capture Coder server metrics with Prometheus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels too separated from the content above about infrastructure metrics.

The idea is that you need to capture 2 kinds of metrics: infrastructure, and Coder-specific, and you want them both to be available in the same system for alerting and dashboards.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if that's because the subheadings under Observability are serving different purposes, with ### Observability key metrics providing more information about a specific aspect, and ### How to capture Coder server metrics with Prometheus showing steps.

I rearranged things in f110af3 to see if that helps the read-through, but I think that if we can add an additional method for capturing metrics and logs, we can split that out into its own H2

Does it make sense to add an example of how to stream coderd or provisionerd logs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry a bit about mixing high-level advice with specific step-by-step instructions, since the step-by-step stuff could change and people might not realize they also have to update this document. I'd much prefer linking so that step-by-step instructions appears in one place for any specific task.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair - that'd be a lot easier with reusable content (embeds/includes/partials, whatever), but as it is now, let's get this out and add relevant links around as we find them

@EdwardAngert EdwardAngert merged commit 02d0650 into main Jan 21, 2025
29 checks passed
@EdwardAngert EdwardAngert deleted the bp-scaling-coder branch January 21, 2025 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
docs Area: coder.com/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants