chore: audit entries for all idp sync changes #15919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Emyrk
commented
Dec 18, 2024
•
Emyrk
commented
Dec 18, 2024
coderd/audit/request.go
Outdated
Comment on lines
136
to
139
| // noID can be used for resources that do not have an uuid. | ||
| // An example is singleton configuration resources. | ||
| // 51A51C = "Static" | ||
| var noID, _ = uuid.Parse("51A51C00-0000-0000-0000-000000000000") |
There was a problem hiding this comment.
I normally use MustParse here, since it'll just silently be a null if it fails.
coadler
approved these changes
Jan 2, 2025
coderd/audit/request.go
Outdated
Comment on lines
136
to
139
| // noID can be used for resources that do not have an uuid. | ||
| // An example is singleton configuration resources. | ||
| // 51A51C = "Static" | ||
| var noID, _ = uuid.Parse("51A51C00-0000-0000-0000-000000000000") |
There was a problem hiding this comment.
I normally use MustParse here, since it'll just silently be a null if it fails.
0bf52c4 to
6b7fd06
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.