chore: add Collapsible component #15961
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aqandrew
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
This is just the result of running pnpm dlx shadcn@latest add collapsible from the shadcn docs, right?
If so then lgtm! I haven't cloned this repo / run Storybook locally yet. I assume you'll adjust the chevron icons + CollapsibleContent indentation for the mobile nav in a separate PR
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component is needed to complete the mobile menu for the navbar refactoring task. You can check out the Figma design here.