Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(Makefile): add shell safety to fmt/go #15974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 30, 2024
Merged

chore(Makefile): add shell safety to fmt/go #15974

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
03e5a9e
chore(Makefile) ignore non go source files when running make fmt/go
SasSwart Dec 29, 2024
4fb0d41
make fmt
SasSwart Dec 29, 2024
037c7a9
oops
SasSwart Dec 29, 2024
ad7820d
ensure that generated files are formatted.
SasSwart Dec 29, 2024
c25f9d9
make fmt
SasSwart Dec 29, 2024
cbde1b5
don't format .pb.go files as they are generated
SasSwart Dec 30, 2024
80e39a0
don't format generated go files
SasSwart Dec 30, 2024
d25cf8a
revert change to gen/mark-fresh
SasSwart Dec 30, 2024
0d445de
chore(Makefile): improve the shell safety of fmt/go
SasSwart Dec 30, 2024
14e0944
Merge remote-tracking branch 'origin/main' into jjs/fmt-go
SasSwart Dec 30, 2024
e8c78c5
cleanup
SasSwart Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,14 +417,14 @@ RESET := $(shell tput sgr0 2>/dev/null)
fmt: fmt/ts fmt/go fmt/terraform fmt/shfmt fmt/prettier
.PHONY: fmt

GO_FMT_FILES := $(shell find . $(FIND_EXCLUSIONS) -type f -name '*.go' -exec sh -c 'grep -L "DO NOT EDIT" "{}" 2>/dev/null || true' \;)

fmt/go:
go mod tidy
echo "$(GREEN)==>$(RESET) $(BOLD)fmt/go$(RESET)"
# VS Code users should check out
# https://github.com/mvdan/gofumpt#visual-studio-code
go run mvdan.cc/[email protected] -w -l $(GO_FMT_FILES)
find . $(FIND_EXCLUSIONS) -type f -name '*.go' -print0 | \
xargs -0 grep --null -L "DO NOT EDIT" | \
xargs -0 go run mvdan.cc/[email protected] -w -l
.PHONY: fmt/go

fmt/ts:
Expand Down
Loading