chore: replace github.com/go-jose/go-jose/v3 with v4#16031
Merged
Conversation
Our codebase currently uses both v3 and v4 versions of the `go-jose` dependency. To maintain consistency, we should standardize on using only the latest v4 version. Signed-off-by: Eng Zer Jun <[email protected]>
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
cdrci2
added a commit
to coder/cla
that referenced
this pull request
Jan 3, 2025
Juneezee
commented
Jan 3, 2025
Contributor
Author
Juneezee
left a comment
There was a problem hiding this comment.
Explaining my changes
| require.Equal(t, appTokenCookie.Path, u.Path, "incorrect path on app token cookie") | ||
|
|
||
| object, err := jose.ParseSigned(appTokenCookie.Value) | ||
| object, err := jose.ParseSigned(appTokenCookie.Value, []jose.SignatureAlgorithm{jwtutils.SigningAlgo}) |
Contributor
Author
There was a problem hiding this comment.
This is the only breaking change that affects us. In v4, jose.ParseSigned requires specifying the algorithms used to sign the signature.
https://github.com/go-jose/go-jose/blob/main/CHANGELOG.md#v400
|
|
||
| const ( | ||
| signingAlgo = jose.HS512 | ||
| SigningAlgo = jose.HS512 |
Contributor
Author
There was a problem hiding this comment.
I exported this constant variable for the jose.ParseSigned function calls in coderd/workspaceapps/apptest/apptest.go. See the previous review comment.
Emyrk
approved these changes
Jan 3, 2025
Member
Emyrk
left a comment
There was a problem hiding this comment.
LGTM 👍
We used v4 in prod, and v3 in tests it seems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
coder/go.mod
Lines 125 to 126 in 4495db8
Our codebase currently uses both v3 and v4 versions of the
go-josedependency. To maintain consistency, we should standardize on using only the latest v4 version.