Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(provisioner/terraform/tfparse): skip evaluation of unrelated parameters (#16023) #16035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(provisioner/terraform/tfparse): skip evaluation of unrelated parameters (#16023) #16035

merged 1 commit into from
Jan 3, 2025

Conversation

stirby
Copy link
Collaborator

@stirby stirby commented Jan 3, 2025

  • Improves tfparse test coverage to include more parameter types and values
  • Adds tests with unrelated parameters that should be ignored by tfparse
  • Modifies tfparse to only attempt evaluation of parameters referenced by coder_workspace_tags

(cherry picked from commit 1ab10cf)

@johnstcn
fix(provisioner/terraform/tfparse): skip evaluation of unrelated para…
0c447d2 
…meters (#16023)

* Improves tfparse test coverage to include more parameter types and values
* Adds tests with unrelated parameters that should be ignored by tfparse
* Modifies tfparse to only attempt evaluation of parameters referenced by coder_workspace_tags

(cherry picked from commit 1ab10cf)
@stirby stirby requested review from johnstcn and matifali January 3, 2025 21:29
@stirby stirby requested review from bpmct and removed request for johnstcn, matifali and bpmct January 3, 2025 21:30
@stirby stirby merged commit 5e71a54 into patch/2.18.2 Jan 3, 2025
28 checks passed
@stirby stirby deleted the cj/patch-2.18.2/16021-skip-no-workspace-tags branch January 3, 2025 21:56
@matifali
Copy link
Member

matifali commented Jan 4, 2025

Why do we merge to patch/2.18 instead of directly to release/2.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@stirby stirby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stirby @matifali @johnstcn