feat(site): connect open_in parameter #16036
Conversation
codersdk/agentsdk/convert_test.go
Outdated
| @@ -64,6 +65,7 @@ func TestManifest(t *testing.T) { | |||
| }, | |||
| Health: codersdk.WorkspaceAppHealthInitializing, | |||
| Hidden: true, | |||
| OpenIn: codersdk.WorkspaceAppOpenInTab, | |||
There was a problem hiding this comment.
We changed the test inputs and it passes with no futher changes? Are we not checking for this in the test?
Should we also add a test with an invalid value for OpenIn?
There was a problem hiding this comment.
I indeed will add some more tests 👀
| @@ -518,6 +518,7 @@ func Apps(dbApps []database.WorkspaceApp, agent database.WorkspaceAgent, ownerNa | |||
| }, | |||
| Health: codersdk.WorkspaceAppHealth(dbApp.Health), | |||
| Hidden: dbApp.Hidden, | |||
| OpenIn: codersdk.WorkspaceAppOpenIn(dbApp.OpenIn), | |||
There was a problem hiding this comment.
This piece is the most important of the PR - basically extracting data from the db to make them be visible in the SDK and API calls.
There was a problem hiding this comment.
I think your description might need updating now.
Also:
Also make sure it is available and forwarded up to the CreateLink component.
Is this present?
Nit:
This PR almost feels too small now; I'm happy to merge it as-is but it might make more sense to combine this change with the new frontend behavior so it's all logically grouped instead of spread out over several PRs.
Second step to resolve open_in issue
This PR improves the way the open_in parameter is forwarded across the code, changing the last
stringto const everywhere.Also make sure it is available and forwarded up to the
CreateLinkcomponent.