chore(examples/templates/azure-windows): remove dependency on az CLI
#16039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matifali
reviewed
Jan 5, 2025
| @@ -31,5 +31,34 @@ This template provisions the following resources: | |||
|
|
|||
| This means, when the workspace restarts, any tools or files outside of the data directory are not persisted. To pre-bake tools into the workspace (e.g. `python3`), modify the VM image, or use a [startup script](https://registry.terraform.io/providers/coder/coder/latest/docs/resources/script). | |||
|
|
|||
| > **Note** | |||
| > [!NOTE] | |||
There was a problem hiding this comment.
Can we render these within Coder?
There was a problem hiding this comment.
Good thinking, will check!
| ```hcl | ||
| # Stop the VM | ||
| resource "null_resource" "stop_vm" { | ||
| count = data.coder_workspace.me.transition == "stop" ? 1 : 0 |
There was a problem hiding this comment.
count = data.coder_workspave.me.start_count
There was a problem hiding this comment.
@matifali I'm not sure though, the issue is that if we use it for stopping, then it will look something like count = data.coder_workspave.me.start_count == 1 ? 0 : 1, we should have data.coder_workspave.me.stop_count i think
There was a problem hiding this comment.
"stop" ? 1 : 0 is fine. Adding a stop_count is too niche.
|
The PR title gives the impression that we are merging the templates into one which we aren't. |
azure-linux and azure-windows templatesaz CLI
spikecurtis
approved these changes
Jan 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that the
azCLI is not necessary anymore to run theazure-windowstemplate, and also unifies the README between the two Azure templates while we're at it.