Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: reduce Windows PG tests flakiness #16090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2025
Merged

chore: reduce Windows PG tests flakiness #16090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ea01035
remove custom wait durations for windows tests
hugodutka Jan 10, 2025
d9741b8
remove Windows build constraint from duration.go
hugodutka Jan 10, 2025
3fa3ea6
reduce test parallelism on windows
hugodutka Jan 10, 2025
5577757
add a comment
hugodutka Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,7 +445,10 @@ jobs:
# C: drive is extremely slow: https://github.com/actions/runner-images/issues/8755
mkdir -p "R:/temp/embedded-pg"
go run scripts/embedded-pg/main.go -path "R:/temp/embedded-pg"
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
# Reduce test parallelism, mirroring what we do for race tests.
# We'd been encountering issues with timing related flakes, and
# this seems to help.
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 -parallel 4 -p 4 ./...
else
go run scripts/embedded-pg/main.go
DB=ci gotestsum --format standard-quiet -- -v -short -count=1 ./...
Expand Down
2 changes: 0 additions & 2 deletions testutil/duration.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
//go:build !windows

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has me worried due to previously not only Windows runners being underpowered but disk I/O was always slower on Windows too. Feel free to have a go at this but I'd advice to be prepared to revert it 😄

package testutil

import (
Expand Down
24 changes: 0 additions & 24 deletions testutil/duration_windows.go
View file
Open in desktop

This file was deleted.

Loading