chore(coderd): remove the window option in open_in #16104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relates to coder/terraform-provider-coder#297 |
johnstcn
reviewed
Jan 13, 2025
| WINDOW = 0; | ||
| SLIM_WINDOW = 1; | ||
| TAB = 2; | ||
| SLIM_WINDOW = 0; |
There was a problem hiding this comment.
Let's keep the WINDOW member but mark it as deprecated.
As discussed, there's no way to remove an enum entry in Postgres so it's probably fine to just leave it lying around instead of the nonsense involved to get it removed properly.
|
@dannykopping @johnstcn as per the comments and discussions we had, I :
|
johnstcn
approved these changes
Jan 15, 2025
|
@defelmnq have we also removed the related changes from https://github.com/coder/terraform-provider-coder? |
Not yet, I merge this one as soon as possible to unblock bruno - but will have to create also one indeed on the tf-provider-coder 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we worked on adding a
open_inparameter for workspace_apps - we initially created three options :After further investigation,
windowshould not be used and has to be removed.ℹ️ I decided to remove the option instead of deprecating it as we've not created any release nor documented the feature. Can be discussed.