Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: predicate slack notification job on other jobs #16106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

dannykopping
Copy link
Contributor

always() does not seem to work

Extending #16105

always() does not seem to work

Signed-off-by: Danny Kopping <[email protected]>
runs-on: ubuntu-latest
if: always() && failure()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

always() && failure() is the same as failure(). I think the operative part here is the needs section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned the operative part in the title, although agree this could've been more explicit.

Clause Sonnet suggested that always() could be used if you wanted to handle all jobs (i.e. not have to exhaustively define needs), but maybe that's wrong.

I hate GHA.

@ethanndickson
Copy link
Member

Also, are you able to test it by manually specifying your branch?
image

@dannykopping
Copy link
Contributor Author

dannykopping commented Jan 13, 2025

Also, are you able to test it by manually specifying your branch? image

I'm busy with other things so didn't bother to check the semantics of the nightly-gauntlet workflow to see if it's work outside of main, but good idea I'll try in my branch first.

"We do this not because it's easy, but because we thought it'd be easy"

@dannykopping
Copy link
Contributor Author

image

Let's goooooo

@dannykopping dannykopping merged commit f9f72de into main Jan 13, 2025
26 of 28 checks passed
@dannykopping dannykopping deleted the dk/nightly2 branch January 13, 2025 11:42
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants